HPC-9975 Remove use-query-params
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onitoxan
added
the
ready for review
Onitoxan
changed the title
use-query-params
unocha-hpc
approved these changes
Dec 16, 2024
unocha-hpc
approved these changes
Dec 19, 2024
It's built on top of `useSearchParams` from `react-router`.
unocha-hpc
approved these changes
Jan 9, 2025
Pl217
requested changes
Jan 10, 2025
Pl217
added
needs minor changes
The proposed solution is to use `setTimeout`, reseting the form and changing the URL are two actions that trigger a re-render. In order to avoid missbehaviours on how they get added to React's event queue, we add a `setTimeout` so the execution is done in the next tick.
unocha-hpc
approved these changes
Jan 13, 2025
unocha-hpc
approved these changes
Jan 13, 2025
Onitoxan
added
ready for review
|
This PR is blocked by ticket HPC-10019, once the work in here is merged we can proceed on merging this PR. It can be reviewed in the meantime. |
unocha-hpc
approved these changes
Jan 14, 2025
Onitoxan
added
the
pending prior merge
unocha-hpc
approved these changes
Jan 17, 2025
Onitoxan
removed
pending prior merge
Pl217
requested changes
Jan 21, 2025
apps/hpc-ftsadmin/src/app/components/filters/filter-organization-table.tsx
Show resolved
Hide resolved
I should have been more specific, no user will manipulate the URL, but nonetheless, us developers we should make sure that nothing too "broken" happens in any case :) |
unocha-hpc
approved these changes
Jan 21, 2025
Pl217
approved these changes
Jan 21, 2025
Onitoxan
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of PR
Description
This PR is related to HPC-9965, read for more context.
In this PR we focus on removing
use-query-paramspackage. It became obsolete since with the use ofreact-routerdata API hooks (precisely,useSearchParams()) and usingio-tsto write runtime validation, we can achieve the same objective.We do this in order to reduce dependency of external libraries.
How to test changes
To test changes I would try to manipulate the URL to see how it reacts even to unexpected
paramsand with wrong data on it.Beside this, I would focus mainly on reading logic for
useQueryParams()to verify it really covers corner cases